Fix: discrepancy protocol parameters #1967

jpraynaud · 2024-09-30T09:34:59Z

Content

This PR includes a fix to the protocol parameters advertised in the /pending-certificate which were different from /epoch-settings route.

Branch
- Crates versions are updated (if relevant)
- Commit sequence broadly makes sense
- Key commits have useful messages
PR
- No clippy warnings in the CI
- Self-reviewed the diff
- Useful pull request description
- Reviewer requested

Closes #1963

- 'mithril-aggregator' from '0.5.69' to '0.5.70'.

github-actions · 2024-09-30T09:42:33Z

4 files ±0 54 suites ±0 9m 39s ⏱️ -5s
1 307 tests ±0 1 307 ✅ ±0 0 💤 ±0 0 ❌ ±0
1 518 runs ±0 1 518 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit e9e24a3. ± Comparison against base commit a5ef7a2.

jpraynaud added 2 commits September 30, 2024 11:31

fix: protocol parameters discrepancy in pending certificate

a81e7e8

chore: bump crates versions

e9e24a3

- 'mithril-aggregator' from '0.5.69' to '0.5.70'.

jpraynaud self-assigned this Sep 30, 2024

Alenar approved these changes Sep 30, 2024

View reviewed changes

jpraynaud requested review from Alenar, sfauvel and dlachaume September 30, 2024 09:42

jpraynaud temporarily deployed to testing-preview September 30, 2024 09:42 — with GitHub Actions Inactive

jpraynaud temporarily deployed to testing-sanchonet September 30, 2024 09:42 — with GitHub Actions Inactive

Alenar approved these changes Sep 30, 2024

View reviewed changes

dlachaume approved these changes Sep 30, 2024

View reviewed changes

jpraynaud merged commit c4e0f0f into main Sep 30, 2024
46 of 49 checks passed

jpraynaud deleted the jpraynaud/1963-fix-discrepancy-protocol-parameters branch September 30, 2024 10:27