-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setting benchmark path #1951
setting benchmark path #1951
Conversation
without benchmark path being stated the mythical docker image fails to build
Hi @Fuma419, thank you for reporting the problem 👍 After investigation, it appears that the problem is due to the bench files not being properly copied in the Docker image. This is something which is already implemented in another Docker image:
Can you update your PR with the same fix in this Docker image? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks for the commit @jpraynaud. Could/should this image be successfully built in a PR check? It seems this one slipped through undetected. |
As the build is quite long for this Docker image, we can not run that in the CI. |
@Fuma419 could you synchronize your fork so that we can bump the version of the Mithril signer? |
Sorry I missed this. Synced now. |
- 'mithril-signer' from '0.2.198' to '0.2.199'.
without benchmark path being stated the mythical docker image fails to build
Content
Here is the log output prior to this fix:
after bugfix:
This PR includes...
Pre-submit checklist
Comments
Issue(s)
Relates to #YYY or Closes #YYY