Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: create new 'Pythagoras' Mithril era #1948

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Feat: create new 'Pythagoras' Mithril era #1948

merged 3 commits into from
Sep 24, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Sep 23, 2024 •
edited
Loading

Content

This PR includes the creation of a new Pythagoras Mithril era.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #1946

@jpraynaud jpraynaud self-assigned this Sep 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

Test Results

    4 files  ±0     54 suites  ±0   9m 42s ⏱️ -10s
1 295 tests ±0  1 295 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 506 runs  ±0  1 506 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9e63511. ± Comparison against base commit 11690e1.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud marked this pull request as ready for review September 23, 2024 15:46
@jpraynaud jpraynaud force-pushed the jpraynaud/1946-create-pythagoras-era branch from 0afc047 to 9e63511 Compare September 24, 2024 07:43
@jpraynaud jpraynaud merged commit 8756930 into main Sep 24, 2024
45 of 65 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/1946-create-pythagoras-era branch September 24, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@sfauvel sfauvel sfauvel approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpraynaud @Alenar @sfauvel @dlachaume