-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make rug-backend
optional for mithril-client
crate
#1884
feat: Make rug-backend
optional for mithril-client
crate
#1884
Conversation
About the CI failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@Mr-Leshiy, thank you for the contribution!
Before we can merge your PR, could you?
- tidy up a bit the commit history as we don't squash commits when merging
- add an entry in the
CHANGELOG.md
file at the root of the repository for this new feature - bump the patch versions of
mithril-client
,mithril-common
andmithril-stm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I would have really liked to avoid using default-features = false
for the mithril-common
import in mithril-client
, but as much as I can scratch my head there's no acceptable alternatives that come in mind.
d282bba
to
62b8a90
Compare
Thanks for your feedback ! I've made requested changes for |
@Mr-Leshiy actually your commits need to be signed in order to be merged in the |
Hi @Mr-Leshiy, on top of signing the commits, could you also sync your fork and make sure that the crates versions in your PR have not already been used by another PR in the mean time? |
ebd225e
to
677be42
Compare
@jpraynaud done 🚀 |
Thanks @Mr-Leshiy, I guess that all the commits need to be signed and I see that only the last one is signed now. We'll be able to merge the PR as soon as this is the case 🚀 |
…ommon and mithril-client crates Signed-off-by: Mr-Leshiy <leshiy12345678@gmail.com>
Signed-off-by: Mr-Leshiy <leshiy12345678@gmail.com>
677be42
to
d5933d2
Compare
Content
To allow disable
LGPL
usage which discussed in, addedrug-backend
feature formithril-client
andmithril-common
crates.Issue(s)
Closes #1786