Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: aggregator and signer blocked during Cardano transactions import #1798

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Fix: aggregator and signer blocked during Cardano transactions import #1798

merged 4 commits into from
Jul 3, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jul 3, 2024 •
edited
Loading

Content

This PR includes a fix to the aggregator and signer nodes which are blocked during the database insertions of the Cardano transactions: the state machines and the REST API were completely inaccessible.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #1797

@jpraynaud
fix: avoid tokio executor blocked in aggregator when importing Cardano
9a6efa1 
transactions

This is happening when sync database code is blocking the executor,
and thus making the node completely unavailable (REST API included).
@jpraynaud
fix: avoid tokio executor blocked in signer when importing Cardano tr…
c17c72d 
…ansactions

This is happening when sync database code is blocking the executor,
and thus making the node completely unavailable.
@jpraynaud
docs: update CHANGELOG
1ce35cb
@jpraynaud
chore: bump crates versions
217f80c 
- 'mithril-aggregator' from '0.5.33' to '0.5.34'
- 'mithril-signer' from '0.2.156' to '0.2.157'.
@jpraynaud jpraynaud self-assigned this Jul 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

Test Results

    4 files  ±0     51 suites  ±0   8m 34s ⏱️ -10s
1 114 tests ±0  1 114 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 262 runs  ±0  1 262 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 217f80c. ± Comparison against base commit e67c830.

@jpraynaud jpraynaud temporarily deployed to testing-sanchonet July 3, 2024 14:08 — with GitHub Actions Inactive
sfauvel
sfauvel approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dlachaume
dlachaume approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud jpraynaud merged commit b87a4c2 into main Jul 3, 2024
39 of 42 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/1797/fix-blocking-ctx-database-insertions branch July 3, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@sfauvel sfauvel sfauvel approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cardano transactions import blocks aggregator and signer
4 participants
@jpraynaud @Alenar @sfauvel @dlachaume