-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditional embedding cardano cli in docker image #1789
Merged
sfauvel
merged 5 commits into
main
from
sfa/1725/conditional_embedding_cardano_cli_in_docker_image
Jul 1, 2024
Merged
Conditional embedding cardano cli in docker image #1789
sfauvel
merged 5 commits into
main
from
sfa/1725/conditional_embedding_cardano_cli_in_docker_image
Jul 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfauvel
temporarily deployed
to
testing-sanchonet
June 28, 2024 12:07
— with
GitHub Actions
Inactive
sfauvel
changed the title
sfa/1725/conditional embedding cardano cli in docker image
Conditional embedding cardano cli in docker image
Jun 28, 2024
jpraynaud
reviewed
Jun 28, 2024
sfauvel
temporarily deployed
to
testing-sanchonet
June 28, 2024 14:15
— with
GitHub Actions
Inactive
sfauvel
force-pushed
the
sfa/1725/conditional_embedding_cardano_cli_in_docker_image
branch
from
June 28, 2024 14:50
b648bd0
to
3da4c38
Compare
sfauvel
temporarily deployed
to
testing-sanchonet
June 28, 2024 14:57
— with
GitHub Actions
Inactive
Alenar
approved these changes
Jul 1, 2024
jpraynaud
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sfauvel
force-pushed
the
sfa/1725/conditional_embedding_cardano_cli_in_docker_image
branch
from
July 1, 2024 13:42
2e6765d
to
4e6e69f
Compare
sfauvel
force-pushed
the
sfa/1725/conditional_embedding_cardano_cli_in_docker_image
branch
from
July 1, 2024 14:15
4704a71
to
4e6e69f
Compare
sfauvel
deleted the
sfa/1725/conditional_embedding_cardano_cli_in_docker_image
branch
July 1, 2024 14:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
By default, build docker images (aggregator and signer) without Cardano CLI which is useless when using Pallas.
We can embed it setting to 1 the build arg EMBED-CARDANO-CLI.
Example:
docker build -t mithril/mithril-aggregator --build-arg EMBED-CARDANO-CLI=1 -f mithril-aggregator/Dockerfile .
Pre-submit checklist
Issue(s)
Closes 1725