Optimize block range roots computation #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flush buffer every 100 root computed to avoid insert queries with more than sqlite max allowed variables.
- 'mithril-aggregator' from '0.4.64' to '0.4.65' - 'mithril-signer' from '0.2.128' to '0.2.129'.
Alenar
approved these changes
Apr 26, 2024
dlachaume
approved these changes
Apr 26, 2024
jpraynaud
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
jpraynaud
deleted the
jpraynaud/1633-optimize-block-range-root-computation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes an optimization on the computation of the block range roots so that there is a limited accumulation of the computed root before they are stored in the database (in particular to avoid the error
variable number must be between ?1 and ?32766from SQLite).Pre-submit checklist
Issue(s)
Relates to #1633