-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle unparsed blocks in Cardano transactions parser #1641
Merged
dlachaume
merged 9 commits into
main
from
damien/1567/handle-unparsed-blocks-in-ctx-parser
Apr 22, 2024
Merged
Handle unparsed blocks in Cardano transactions parser #1641
dlachaume
merged 9 commits into
main
from
damien/1567/handle-unparsed-blocks-in-ctx-parser
Apr 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlachaume
changed the title
Handle unparsed blocks in ctx parser
Handle unparsed blocks in Cardano transactions parser
Apr 18, 2024
dlachaume
had a problem deploying
to
testing-preview
April 18, 2024 13:36
— with
GitHub Actions
Failure
dlachaume
temporarily deployed
to
testing-sanchonet
April 18, 2024 13:37
— with
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-preview
April 18, 2024 14:06
— with
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
April 18, 2024 14:06
— with
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-preview
April 18, 2024 14:36
— with
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
April 18, 2024 14:36
— with
GitHub Actions
Inactive
dlachaume
force-pushed
the
damien/1567/handle-unparsed-blocks-in-ctx-parser
branch
from
April 19, 2024 09:19
07d9882
to
7df3a7d
Compare
This function evaluate the possibility of validating the request to allow unparsable block or not, depending on the target Cardano network.
Add 'allow_unparsable_block' clap argument and Configuration parameter.
Add 'allow_unparsable_block' clap argument and Configuration parameter.
dlachaume
had a problem deploying
to
testing-preview
April 19, 2024 09:25
— with
GitHub Actions
Failure
dlachaume
had a problem deploying
to
testing-sanchonet
April 19, 2024 09:25
— with
GitHub Actions
Failure
dlachaume
force-pushed
the
damien/1567/handle-unparsed-blocks-in-ctx-parser
branch
from
April 19, 2024 09:28
7df3a7d
to
f5a3fd1
Compare
dlachaume
had a problem deploying
to
testing-preview
April 19, 2024 09:35
— with
GitHub Actions
Failure
dlachaume
had a problem deploying
to
testing-sanchonet
April 19, 2024 09:35
— with
GitHub Actions
Failure
dlachaume
force-pushed
the
damien/1567/handle-unparsed-blocks-in-ctx-parser
branch
from
April 19, 2024 09:36
f5a3fd1
to
452058a
Compare
dlachaume
had a problem deploying
to
testing-preview
April 19, 2024 09:42
— with
GitHub Actions
Failure
dlachaume
had a problem deploying
to
testing-sanchonet
April 19, 2024 09:42
— with
GitHub Actions
Failure
jpraynaud
reviewed
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good 👍
.github/workflows/actions/deploy-terraform-infrastructure/action.yml
Outdated
Show resolved
Hide resolved
dlachaume
temporarily deployed
to
testing-preview
April 19, 2024 10:01
— with
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
April 19, 2024 10:01
— with
GitHub Actions
Inactive
dlachaume
force-pushed
the
damien/1567/handle-unparsed-blocks-in-ctx-parser
branch
from
April 19, 2024 10:07
452058a
to
5d06859
Compare
dlachaume
temporarily deployed
to
testing-preview
April 19, 2024 10:13
— with
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
April 19, 2024 10:13
— with
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-preview
April 19, 2024 10:23
— with
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
April 19, 2024 10:23
— with
GitHub Actions
Inactive
jpraynaud
reviewed
Apr 19, 2024
dlachaume
force-pushed
the
damien/1567/handle-unparsed-blocks-in-ctx-parser
branch
from
April 19, 2024 12:22
3f5c96c
to
5b6cbcd
Compare
- Rename function 'allow_unparsable_block' to 'compute_allow_unparsable_block' and clarify its comment - Add reference to pre-production network in 'allow_unparsable_block' comments
dlachaume
force-pushed
the
damien/1567/handle-unparsed-blocks-in-ctx-parser
branch
from
April 19, 2024 12:24
5b6cbcd
to
25c8d02
Compare
jpraynaud
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
dlachaume
temporarily deployed
to
testing-preview
April 19, 2024 12:31
— with
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
April 19, 2024 12:31
— with
GitHub Actions
Inactive
Alenar
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes an update that adds a new configuration parameter to the Aggregator and Signer node. It allows to configure the behavior of the Cardano transactions parser with unparsed blocks (return or log the error).
The default value of the new parameter
allow_unparsable_block
is set tofalse
, which returns an error when a block can't be parsed.For
mainnet
andpreprod
networks, the value is forced tofalse
, even if the parameter is set totrue
, to always return an error on stable networks.Pre-submit checklist
Issue(s)
Closes #1567