Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New migration to add indexes on foreign keys #1609

Merged
merged 2 commits into from
Apr 3, 2024
Merged

New migration to add indexes on foreign keys #1609

merged 2 commits into from
Apr 3, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Apr 3, 2024 •
edited
Loading

Content

This PR includes a new migration for the aggregator node database.
The migration creates indexes on foreign keys columns.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

Indexes are named tablecolumn_index to avoid conflicts when columns have the same name in different tables.

Issue(s)

Closes #1603

@dlachaume dlachaume self-assigned this Apr 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024 •
edited
Loading

Test Results

    3 files  ±0     42 suites  ±0   8m 25s ⏱️ -52s
  946 tests ±0    946 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 040 runs  ±0  1 040 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 505b1eb. ± Comparison against base commit 42f4432.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume marked this pull request as ready for review April 3, 2024 07:39
jpraynaud
jpraynaud approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume
Add new migration in aggregator db
0307303 
This migration adds indexes for foreign keys
@dlachaume
Update crate version
505b1eb
@dlachaume dlachaume force-pushed the damien/1603/add-indexes-on-foreign-keys branch from 2d13e1c to 505b1eb Compare April 3, 2024 09:12
@dlachaume dlachaume merged commit d89b76c into main Apr 3, 2024
41 checks passed
@dlachaume dlachaume deleted the damien/1603/add-indexes-on-foreign-keys branch April 3, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@sfauvel sfauvel sfauvel approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add indexes on foreign keys of SQLite stores
4 participants
@dlachaume @Alenar @sfauvel @jpraynaud