Fix Conway transactions parsing #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Conway transaction parsing issue from '0.24.0'
Alenar
approved these changes
Apr 2, 2024
jpraynaud
force-pushed
the
jpraynaud/1577-fix-transaction-parsing-conway
branch
from
7473f3e
to
2ab685f
Compare
This avoids versions mismatch and error messages like: 'pallas_crypto::hash::Hash<32>' and 'pallas_crypto::hash::hash::Hash<32>' have similar names, but are actually distinct types perhaps two different versions of crate 'pallas_crypto' are being used.
jpraynaud
force-pushed
the
jpraynaud/1577-fix-transaction-parsing-conway
branch
from
2ab685f
to
30d7af0
Compare
jpraynaud
force-pushed
the
jpraynaud/1577-fix-transaction-parsing-conway
branch
from
30d7af0
to
e580e25
Compare
This was not the case anymore with pallas '0.25.0'.
jpraynaud
force-pushed
the
jpraynaud/1577-fix-transaction-parsing-conway
branch
from
e580e25
to
17300f7
Compare
jpraynaud
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
sfauvel
approved these changes
Apr 3, 2024
dlachaume
approved these changes
Apr 3, 2024
Alenar
approved these changes
Apr 3, 2024
- 'mithril-common' from '0.3.26' to '0.3.27'.
jpraynaud
force-pushed
the
jpraynaud/1577-fix-transaction-parsing-conway
branch
from
17300f7
to
42b42e3
Compare
jpraynaud
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a fix to the Conway transactions parsing which failed for some blocks with the previous version of
pallas(bumped from0.24.0to0.25.0). Also re-activated the stop on error in the Cardano transaction parser.Pre-submit checklist
Issue(s)
Closes #1577