-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and persist slot_number
and block_hash
to CardanoTransaction
#1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfauvel
force-pushed
the
ensemble/1591/incremental-storage-for-cardano-tx
branch
from
April 2, 2024 08:54
59ea0ad
to
8cc9e95
Compare
sfauvel
temporarily deployed
to
testing-sanchonet
April 2, 2024 09:33
— with
GitHub Actions
Inactive
sfauvel
temporarily deployed
to
testing-sanchonet
April 2, 2024 09:41
— with
GitHub Actions
Inactive
jpraynaud
reviewed
Apr 2, 2024
mithril-aggregator/src/database/provider/cardano_transaction.rs
Outdated
Show resolved
Hide resolved
mithril-aggregator/src/database/provider/cardano_transaction.rs
Outdated
Show resolved
Hide resolved
mithril-aggregator/src/database/provider/cardano_transaction.rs
Outdated
Show resolved
Hide resolved
jpraynaud
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
sfauvel
temporarily deployed
to
testing-sanchonet
April 2, 2024 13:36
— with
GitHub Actions
Inactive
dlachaume
reviewed
Apr 2, 2024
dlachaume
reviewed
Apr 2, 2024
dlachaume
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two comments, otherwise LGTM 🚀
sfauvel
force-pushed
the
ensemble/1591/incremental-storage-for-cardano-tx
branch
from
April 2, 2024 14:14
3f1e93c
to
3ee8398
Compare
sfauvel
temporarily deployed
to
testing-sanchonet
April 2, 2024 14:21
— with
GitHub Actions
Inactive
sfauvel
force-pushed
the
ensemble/1591/incremental-storage-for-cardano-tx
branch
from
April 2, 2024 14:23
3ee8398
to
a869994
Compare
sfauvel
temporarily deployed
to
testing-sanchonet
April 2, 2024 14:31
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR add two new fields to our
CardanoTransaction
type:slot_number
andblock_hash
. This will allow comparison between a transaction and their incoming beacon that will include them (and theblock_number
that's already a part of our transaction type).Pre-submit checklist
Comments
To update the database provider part of the mithril-signer we simply copy-pasted the update one from the aggregator, adapted the import and removed the part that implemented traits not defined in the signer.
We choose to keep all the remaining code even if it's not used in the signer in order to keep as much as possible a parity between the aggregator and the signer file as long as they're still manipulating the same data.
Issue(s)
Relates to #1591