Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade bech32 crate #1592

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Upgrade bech32 crate #1592

merged 3 commits into from
Mar 27, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Mar 26, 2024 •
edited
Loading

Content

This PR includes the update of crate bech32 to version 0.11.0 which introduced some breaking change in the API.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@jpraynaud jpraynaud self-assigned this Mar 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2024 •
edited
Loading

Test Results

    3 files  ±0     42 suites  ±0   9m 25s ⏱️ +34s
  946 tests +1    946 ✅ +1  0 💤 ±0  0 ❌ ±0 
1 040 runs  +1  1 040 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 3fdf308. ± Comparison against base commit f1bd564.

♻️ This comment has been updated with latest results.

sfauvel
sfauvel approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good

@jpraynaud
chore: use 'bech32' new '0.11.0' version
eb5c16a 
Which also introduced some breaking change in the API that are fixed in this commit.
@jpraynaud jpraynaud force-pushed the jpraynaud/upgrade-bech32-crate branch from 9d68cf5 to 451bc2a Compare March 26, 2024 17:53
@jpraynaud jpraynaud force-pushed the jpraynaud/upgrade-bech32-crate branch from 451bc2a to 3fdf308 Compare March 27, 2024 08:44
@jpraynaud jpraynaud merged commit 950636b into main Mar 27, 2024
40 of 41 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/upgrade-bech32-crate branch March 27, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@sfauvel sfauvel sfauvel approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpraynaud @Alenar @sfauvel