Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mithril client CLI: fix remove archive directory #1517

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Mithril client CLI: fix remove archive directory #1517

merged 2 commits into from
Feb 22, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Feb 21, 2024 •
edited by Alenar
Loading

Content

This PR includes a regression after the merge of the PR #1395 related to the snapshot download command of mithril-client-cli.
The unpack directory was no longer removed when the certificate signed message and computed message did not match.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2024 •
edited
Loading

Test Results

  3 files  ±0   42 suites  ±0   8m 48s ⏱️ +18s
864 tests +1  864 ✅ +1  0 💤 ±0  0 ❌ ±0 
953 runs  +3  953 ✅ +3  0 💤 ±0  0 ❌ ±0 

Results for commit e908b88. ± Comparison against base commit e1f37ee.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume self-assigned this Feb 21, 2024
jpraynaud
jpraynaud reviewed Feb 21, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test that behavior also?

@dlachaume dlachaume force-pushed the damien/fix-remove-archive-directory-snapshot-download-command branch from 6a2099f to 229c19d Compare February 21, 2024 16:53
@dlachaume
Copy link
Collaborator Author

Can we test that behavior also?

@jpraynaud, I've added a UT to verify the directory deletion.

jpraynaud
jpraynaud approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

mithril-client-cli/src/commands/snapshot/download.rs Show resolved Hide resolved
@dlachaume dlachaume force-pushed the damien/fix-remove-archive-directory-snapshot-download-command branch from 229c19d to e908b88 Compare February 21, 2024 17:56
@dlachaume dlachaume marked this pull request as ready for review February 21, 2024 18:01
@dlachaume dlachaume merged commit 0d47097 into main Feb 22, 2024
40 of 48 checks passed
@dlachaume dlachaume deleted the damien/fix-remove-archive-directory-snapshot-download-command branch February 22, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@sfauvel sfauvel Awaiting requested review from sfauvel

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlachaume @Alenar @jpraynaud