Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Cardano transactions verification in mithril-client-wasm #1512

Merged

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Feb 19, 2024

Content

This PR includes an update of mithril-client-wasm to handle the Cardano transactions functionnalities exposed by mithril-client crate.

In order to implement Cardano transaction tests in the WASM library, the mechanism that sets up the default data of mithril-aggregator-fake had to be improved. Build scripts now generate useful Rust code for testing, containing all default data. Data can be generated by the import.sh script of the mithril-aggregator-fake and stored in JSON files located in mithril-test-lab/mithril-aggregator-fake/default_data.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1470

Copy link

github-actions bot commented Feb 19, 2024

Test Results

  3 files  ± 0   42 suites  +1   8m 35s ⏱️ -7s
863 tests +17  863 ✅ +17  0 💤 ±0  0 ❌ ±0 
950 runs  +17  950 ✅ +17  0 💤 ±0  0 ❌ ±0 

Results for commit f93058a. ± Comparison against base commit 9eb6467.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume force-pushed the ensemble/1470/implement-cardano-transactions-verification-wasm branch from e479443 to 6b1446e Compare February 19, 2024 17:17
@dlachaume dlachaume changed the title Ensemble/1470/implement cardano transactions verification wasm Implement Cardano transactions verification in mithril-client-wasm Feb 19, 2024
@dlachaume dlachaume force-pushed the ensemble/1470/implement-cardano-transactions-verification-wasm branch 3 times, most recently from 3e1a72e to 0f513bb Compare February 19, 2024 19:04
@dlachaume dlachaume marked this pull request as ready for review February 19, 2024 19:23
@dlachaume dlachaume force-pushed the ensemble/1470/implement-cardano-transactions-verification-wasm branch from b5ab8a6 to c01adcb Compare February 20, 2024 09:41
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left few comments, but overall looks good 🙂

.github/workflows/test-client.yml Outdated Show resolved Hide resolved
docs/website/root/glossary.md Outdated Show resolved Hide resolved
docs/website/root/glossary.md Outdated Show resolved Hide resolved
mithril-build-script/Cargo.toml Show resolved Hide resolved
mithril-client-wasm/README.md Outdated Show resolved Hide resolved
mithril-client-wasm/src/client_wasm.rs Outdated Show resolved Hide resolved
@dlachaume dlachaume force-pushed the ensemble/1470/implement-cardano-transactions-verification-wasm branch 3 times, most recently from 330853f to c3761d5 Compare February 21, 2024 10:46
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I commented few typos to fix before merging.

mithril-build-script/Cargo.toml Outdated Show resolved Hide resolved
mithril-build-script/README.md Outdated Show resolved Hide resolved
@dlachaume dlachaume force-pushed the ensemble/1470/implement-cardano-transactions-verification-wasm branch from c3761d5 to f93058a Compare February 21, 2024 11:20
@dlachaume dlachaume merged commit e1f37ee into main Feb 21, 2024
40 of 49 checks passed
@dlachaume dlachaume deleted the ensemble/1470/implement-cardano-transactions-verification-wasm branch February 21, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Cardano Transactions verification in the WASM client
4 participants