-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Cardano transactions verification in mithril-client-wasm
#1512
Merged
dlachaume
merged 32 commits into
main
from
ensemble/1470/implement-cardano-transactions-verification-wasm
Feb 21, 2024
Merged
Implement Cardano transactions verification in mithril-client-wasm
#1512
dlachaume
merged 32 commits into
main
from
ensemble/1470/implement-cardano-transactions-verification-wasm
Feb 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlachaume
force-pushed
the
ensemble/1470/implement-cardano-transactions-verification-wasm
branch
from
February 19, 2024 17:17
e479443
to
6b1446e
Compare
dlachaume
changed the title
Ensemble/1470/implement cardano transactions verification wasm
Implement Cardano transactions verification in Feb 19, 2024
mithril-client-wasm
dlachaume
force-pushed
the
ensemble/1470/implement-cardano-transactions-verification-wasm
branch
3 times, most recently
from
February 19, 2024 19:04
3e1a72e
to
0f513bb
Compare
dlachaume
temporarily deployed
to
testing-preview
February 19, 2024 19:16
— with
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
February 19, 2024 19:16
— with
GitHub Actions
Inactive
dlachaume
force-pushed
the
ensemble/1470/implement-cardano-transactions-verification-wasm
branch
from
February 20, 2024 09:41
b5ab8a6
to
c01adcb
Compare
Alenar
approved these changes
Feb 20, 2024
dlachaume
temporarily deployed
to
testing-preview
February 20, 2024 10:27
— with
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
February 20, 2024 10:27
— with
GitHub Actions
Inactive
jpraynaud
reviewed
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left few comments, but overall looks good 🙂
docs/website/root/manual/developer-docs/nodes/mithril-client-library-wasm.md
Outdated
Show resolved
Hide resolved
docs/website/root/manual/developer-docs/nodes/mithril-client-library-wasm.md
Outdated
Show resolved
Hide resolved
- fix epoch settings - refacto `generate_code` function
…ation of tmp file
…pt::FakeAggregatorData
…tor 'default_data' json files Add `get_cardano_transaction_set` function
… fake aggregator import script
…roof_message` in `client_wasm`
dlachaume
force-pushed
the
ensemble/1470/implement-cardano-transactions-verification-wasm
branch
3 times, most recently
from
February 21, 2024 10:46
330853f
to
c3761d5
Compare
jpraynaud
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I commented few typos to fix before merging.
dlachaume
force-pushed
the
ensemble/1470/implement-cardano-transactions-verification-wasm
branch
from
February 21, 2024 11:20
c3761d5
to
f93058a
Compare
dlachaume
temporarily deployed
to
testing-preview
February 21, 2024 11:35
— with
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
February 21, 2024 11:35
— with
GitHub Actions
Inactive
dlachaume
deleted the
ensemble/1470/implement-cardano-transactions-verification-wasm
branch
February 21, 2024 11:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes an update of
mithril-client-wasm
to handle the Cardano transactions functionnalities exposed bymithril-client
crate.In order to implement Cardano transaction tests in the WASM library, the mechanism that sets up the default data of
mithril-aggregator-fake
had to be improved. Build scripts now generate useful Rust code for testing, containing all default data. Data can be generated by theimport.sh
script of themithril-aggregator-fake
and stored in JSON files located inmithril-test-lab/mithril-aggregator-fake/default_data
.Pre-submit checklist
Issue(s)
Closes #1470