Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example crate for Cardano transactions #1511

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Add example crate for Cardano transactions #1511

merged 3 commits into from
Feb 20, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Feb 19, 2024 •
edited
Loading

Content

This PR includes a new example crate for Cardano transactions.

Optional parameters have also been added to the previous examples to enable execution on different networks.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1495

@dlachaume dlachaume self-assigned this Feb 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2024 •
edited
Loading

Test Results

  3 files  ±0   40 suites  ±0   8m 37s ⏱️ -19s
830 tests ±0  830 ✅ ±0  0 💤 ±0  0 ❌ ±0 
917 runs  ±0  917 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit bc4933e. ± Comparison against base commit 4cbbec8.

♻️ This comment has been updated with latest results.

jpraynaud
jpraynaud reviewed Feb 19, 2024
View reviewed changes
examples/client-cardano-transaction/README.md Outdated Show resolved Hide resolved
examples/client-cardano-transaction/README.md Outdated Show resolved Hide resolved
examples/client-cardano-transaction/README.md Outdated Show resolved Hide resolved
examples/client-cardano-transaction/src/main.rs Outdated Show resolved Hide resolved
examples/client-cardano-transaction/src/main.rs Outdated Show resolved Hide resolved
@dlachaume dlachaume force-pushed the damien/1495/add-example-crate-for-cardano-transactions branch from d4771e3 to c084b90 Compare February 20, 2024 07:24
jpraynaud
jpraynaud approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume force-pushed the damien/1495/add-example-crate-for-cardano-transactions branch from c084b90 to bc4933e Compare February 20, 2024 13:39
@dlachaume dlachaume merged commit 1c37f60 into main Feb 20, 2024
40 of 41 checks passed
@dlachaume dlachaume deleted the damien/1495/add-example-crate-for-cardano-transactions branch February 20, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@sfauvel sfauvel Awaiting requested review from sfauvel

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an example crate for the CardanoTransactions type
3 participants
@dlachaume @Alenar @jpraynaud