Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SPO-on-boarding-guide.md, it's not required (anymore?) to run … #1507

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Update SPO-on-boarding-guide.md, it's not required (anymore?) to run … #1507

merged 3 commits into from
Feb 15, 2024

Conversation

brouwerQ
Copy link
Contributor

…Mithril on preprod before you can run it on mainnet

Content

This PR includes...

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

Issue(s)

Relates to #YYY or Closes #YYY

@brouwerQ
Update SPO-on-boarding-guide.md, it's not required (anymore?) to run …
2384249 
…Mithril on preprod before you can run it on mainnet
jpraynaud
jpraynaud requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brouwerQ for this PR 🙂

I have made few suggestions as running on preprod is a strongly encouraged step before running on mainnet.

docs/website/versioned_docs/version-maintained/manual/getting-started/SPO-on-boarding-guide.md Outdated Show resolved Hide resolved
docs/website/versioned_docs/version-maintained/manual/getting-started/SPO-on-boarding-guide.md Outdated Show resolved Hide resolved
docs/website/versioned_docs/version-maintained/manual/getting-started/SPO-on-boarding-guide.md Outdated Show resolved Hide resolved
brouwerQ and others added 2 commits February 15, 2024 11:50
@brouwerQ @jpraynaud
Apply suggestions from code review
31145fb 
Co-authored-by: Jean-Philippe Raynaud <jp.raynaud@gmail.com>
@brouwerQ
Update SPO-on-boarding-guide.md - beforehand
4fa37a8
jpraynaud
jpraynaud approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud jpraynaud merged commit 4cbbec8 into input-output-hk:main Feb 15, 2024
36 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@olgahryniuk olgahryniuk olgahryniuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brouwerQ @jpraynaud @olgahryniuk