Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract persistence related code to a new shared crate #1494

Merged
merged 9 commits into from
Feb 13, 2024
Merged

Extract persistence related code to a new shared crate #1494

merged 9 commits into from
Feb 13, 2024

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Feb 9, 2024 •
edited
Loading

Content

This PR create a new shared crate, mithril-persistence. All all store & database related code from mithril-common has been moved to it.

This makes enhance our code base maintainability, reduce the dependencies of the mithril-common crate, allow to remove its database feature.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1492.

@Alenar Alenar self-assigned this Feb 9, 2024
@Alenar Alenar requested review from jpraynaud and removed request for ghubertpalo February 9, 2024 17:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024 •
edited
Loading

Test Results

  3 files  ±0   37 suites  +1   9m 8s ⏱️ +34s
828 tests ±0  828 ✅ ±0  0 💤 ±0  0 ❌ ±0 
913 runs  ±0  913 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 535ba5a. ± Comparison against base commit f31f1ec.

♻️ This comment has been updated with latest results.

jpraynaud
jpraynaud approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I left few comments for typos below. Also, should we bump the minor version of mithril-common as we changed the available features in the crate?

mithril-persistence/README.md Outdated Show resolved Hide resolved
mithril-persistence/README.md Outdated Show resolved Hide resolved
mithril-persistence/src/database/signed_entity_hydrator.rs Outdated Show resolved Hide resolved
mithril-persistence/src/lib.rs Outdated Show resolved Hide resolved
@Alenar
Copy link
Collaborator Author

Alenar commented Feb 12, 2024

Also, should we bump the minor version of mithril-common as we changed the available features in the crate?

Yup, bumping the minor version of mithril-common was on my mind .

@Alenar Alenar merged commit 141d0ad into main Feb 13, 2024
40 of 50 checks passed
@Alenar Alenar deleted the djo/1492/mithril-db-crate branch February 13, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@dlachaume dlachaume dlachaume approved these changes

@sfauvel sfauvel Awaiting requested review from sfauvel

Assignees

@Alenar Alenar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract database feature from common crate
3 participants
@Alenar @jpraynaud @dlachaume