Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CardanoTransactions artifact routes in aggregator #1479

Merged
merged 12 commits into from
Feb 1, 2024
Merged

Implement CardanoTransactions artifact routes in aggregator #1479

merged 12 commits into from
Feb 1, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jan 31, 2024 •
edited
Loading

Content

This PR includes the new routes in the aggregator REST API which give access to the CardanoTransactions artifacts.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #1478

@jpraynaud jpraynaud self-assigned this Jan 31, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2024 •
edited
Loading

Test Results

  3 files  ± 0   33 suites  ±0   9m 24s ⏱️ +19s
811 tests +13  811 ✅ +13  0 💤 ±0  0 ❌ ±0 
884 runs  +13  884 ✅ +13  0 💤 ±0  0 ❌ ±0 

Results for commit e24aec5. ± Comparison against base commit 537ef89.

♻️ This comment has been updated with latest results.

dlachaume
dlachaume approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Alenar
Alenar approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few comments :)

mithril-common/src/test_utils/fake_data.rs Outdated Show resolved Hide resolved
mithril-common/src/entities/cardano_transactions_commitment.rs Show resolved Hide resolved
mithril-aggregator/src/http_server/routes/artifact_routes/cardano_transaction.rs Outdated Show resolved Hide resolved
@jpraynaud jpraynaud force-pushed the jpraynaud/1467-cardano-transactions-artifact-routes branch from d9e3d0f to 41a4a35 Compare February 1, 2024 11:00
@jpraynaud
refactor: common 'setup_router' function in artifact routes module
c386aab
@jpraynaud
chore: update OpenAPI version
14be119 
From '0.1.14' to '0.1.15'.
@jpraynaud
chore: update crates versions
e24aec5 
- mithril-aggregator: from  '0.4.31' to  '0.4.32'
- mithril-common: from  '0.2.158' to  '0.2.159'
- mithril-end-to-end: from  '0.2.36' to  '0.2.37'.
@jpraynaud jpraynaud force-pushed the jpraynaud/1467-cardano-transactions-artifact-routes branch from 41a4a35 to e24aec5 Compare February 1, 2024 11:53
@jpraynaud jpraynaud merged commit 69adabe into main Feb 1, 2024
36 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/1467-cardano-transactions-artifact-routes branch February 1, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement artifact routes in the aggregator
3 participants
@jpraynaud @Alenar @dlachaume