-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sfa/improve signed entity test #1460
Sfa/improve signed entity test #1460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like your branch is far behind as there should also be a build_artifact_for_cardano_transactions_store_nothing_in_db
test to adapt in this module 🤔
Otherwise LGTM 👍
b1a90f0
to
3a22e8b
Compare
I rebased to main |
I add 3 versions of the same test on create_artifact.
|
ef064a6
to
64543bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
It looks like the |
@sfauvel can you fix the clippy warning and bump the patch version of the aggregator? |
28c4db0
to
6941472
Compare
a636a55
to
d9d71ae
Compare
Content
Simplification proposal for signed_entity tests to improve understanding by hiding some technical code.
Pre-submit checklist
Comments
To hide code needed to handle mocks, a MockDependencyInjector struct is added.
It creates and keeps all mocks needed during tests.
It provide functions that build struct with mocks.
Issue(s)
Relates to #YYY or Closes #YYY