Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix npm badge in mithril-client-wasm README files #1458

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Fix npm badge in mithril-client-wasm README files #1458

merged 2 commits into from
Jan 24, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jan 24, 2024 •
edited
Loading

Content

This PR includes a fix in the README files of mithril-client-wasm.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)

jpraynaud
jpraynaud approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

Test Results

  3 files  ±0   33 suites  ±0   8m 45s ⏱️ +19s
778 tests ±0  778 ✅ ±0  0 💤 ±0  0 ❌ ±0 
851 runs  ±0  851 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4c852de. ± Comparison against base commit 88c59ab.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume merged commit c762166 into main Jan 24, 2024
35 checks passed
@dlachaume dlachaume deleted the damien/fix-npm-badge-in-wasm-readme branch January 24, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlachaume @jpraynaud