Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute message to sign for Cardano transactions #1455

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jan 24, 2024

Content

This PR includes:

  • Computation of the Merkle tree of the Cardano transactions set and the associated Merkle root
  • Use the Merkle root as a protocol message part to be signed in the signer and aggregator

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #1436

Copy link

github-actions bot commented Jan 24, 2024

Test Results

  3 files  ±0   33 suites  ±0   8m 53s ⏱️ - 1m 37s
784 tests +6  784 ✅ +6  0 💤 ±0  0 ❌ ±0 
857 runs  +6  857 ✅ +6  0 💤 ±0  0 ❌ ±0 

Results for commit 50c9bc7. ± Comparison against base commit c762166.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the ensemble/1436-sign-cardano-transactions branch from 5dc94a2 to 50c9bc7 Compare January 25, 2024 11:04
@jpraynaud jpraynaud marked this pull request as ready for review January 25, 2024 11:07
@jpraynaud jpraynaud merged commit ba96064 into main Jan 25, 2024
35 of 40 checks passed
@jpraynaud jpraynaud deleted the ensemble/1436-sign-cardano-transactions branch January 25, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Light Wallet: Compute message to sign for CardanoTransactions
3 participants