Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increment mithril-client-wasm version for npm publish #1453

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Increment mithril-client-wasm version for npm publish #1453

merged 1 commit into from
Jan 23, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jan 23, 2024 •
edited
Loading

Content

This PR includes an update of mithril-client-wasm crate version to authorize publishing on npm.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@dlachaume dlachaume changed the title Update crate version Increment mithril-client-wasm version for npm publish Jan 23, 2024
@dlachaume dlachaume self-assigned this Jan 23, 2024
@dlachaume dlachaume marked this pull request as ready for review January 23, 2024 13:38
@github-actions GitHub Actions
Copy link

Test Results

  3 files  ±0   33 suites  ±0   8m 39s ⏱️ +16s
760 tests ±0  760 ✅ ±0  0 💤 ±0  0 ❌ ±0 
833 runs  ±0  833 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6215516. ± Comparison against base commit 8a199d7.

jpraynaud
jpraynaud approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume merged commit ed1b86d into main Jan 23, 2024
32 checks passed
@dlachaume dlachaume deleted the damien/increment-mithril-client-wasm-version-for-npm-publish branch January 23, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlachaume @jpraynaud