Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cardano configuration in infrastructure #1442

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jan 17, 2024

Content

This PR includes a fix on the Cardano configurations deployed by terraform in the infrastructure:

  • Use correct commit id on 'cardano-configurations' repository to work with Cardano node 8.7.3.
  • Use the _p2p suffixed folders to have P2P enabled by default in Cardano node config files.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #1410

- Use correct commit id on 'cardano-configurations' repository to work
  with Cardano node '8.7.3'.
- Use the '_p2p' suffixed folders to have P2P enabled by default in
  Cardano node config files.
Copy link

Test Results

  3 files  ±0   32 suites  ±0   8m 38s ⏱️ +10s
739 tests ±0  739 ✅ ±0  0 💤 ±0  0 ❌ ±0 
812 runs  ±0  812 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 394d48c. ± Comparison against base commit 2982a54.

@jpraynaud jpraynaud merged commit 0fb37f4 into main Jan 17, 2024
35 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/1410-fix-cardano-configuration-infra branch January 17, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants