Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement fake aggregator in wasm tests #1441

Merged
merged 5 commits into from
Jan 19, 2024
Merged

Implement fake aggregator in wasm tests #1441

merged 5 commits into from
Jan 19, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jan 17, 2024 •
edited
Loading

Content

This PR includes tests for mithril-client-wasm.

  • The Makefile was updated to start a mithril-aggregator-fake when the command make test is executed.
  • A job was added in the CI to start a mithril-aggregator-fake before running the tests.
  • Tests in mithril-client-wasm were updated with the default values of mithril-aggregator-fake

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1407

@dlachaume dlachaume force-pushed the ensemble/1407/implement-fake-aggregator-in-wasm-tests branch from 788ac31 to 14df6c8 Compare January 17, 2024 13:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2024 •
edited
Loading

Test Results

  3 files  ±0   33 suites  ±0   8m 29s ⏱️ +6s
760 tests ±0  760 ✅ ±0  0 💤 ±0  0 ❌ ±0 
833 runs  ±0  833 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7323570. ± Comparison against base commit a142158.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume force-pushed the ensemble/1407/implement-fake-aggregator-in-wasm-tests branch 3 times, most recently from f203cfc to b9824d4 Compare January 17, 2024 14:27
@dlachaume dlachaume force-pushed the ensemble/1407/implement-fake-aggregator-in-wasm-tests branch from b9824d4 to 0179b0f Compare January 17, 2024 14:37
@dlachaume dlachaume self-assigned this Jan 17, 2024
jpraynaud
jpraynaud reviewed Jan 17, 2024
View reviewed changes
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
mithril-client-wasm/Makefile Show resolved Hide resolved
@dlachaume dlachaume force-pushed the ensemble/1407/implement-fake-aggregator-in-wasm-tests branch 3 times, most recently from c905a06 to c8a8529 Compare January 17, 2024 17:55
Base automatically changed from greg/1397/fake_aggregator to main January 18, 2024 10:53
jpraynaud
jpraynaud approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume force-pushed the ensemble/1407/implement-fake-aggregator-in-wasm-tests branch from c8a8529 to f74b29d Compare January 18, 2024 11:24
@dlachaume dlachaume force-pushed the ensemble/1407/implement-fake-aggregator-in-wasm-tests branch from 0c48af8 to fb2cde0 Compare January 18, 2024 16:48
@dlachaume dlachaume force-pushed the ensemble/1407/implement-fake-aggregator-in-wasm-tests branch from fb2cde0 to 6560c9a Compare January 18, 2024 17:49
@dlachaume dlachaume force-pushed the ensemble/1407/implement-fake-aggregator-in-wasm-tests branch from 6560c9a to 7323570 Compare January 19, 2024 08:08
@dlachaume dlachaume merged commit 31cd6e2 into main Jan 19, 2024
35 checks passed
@dlachaume dlachaume deleted the ensemble/1407/implement-fake-aggregator-in-wasm-tests branch January 19, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@ghubertpalo ghubertpalo Awaiting requested review from ghubertpalo

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Light Wallet: Implement browser tests with fake aggregator
3 participants
@dlachaume @Alenar @jpraynaud