-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement mithril client wasm in explorer #1426
Implement mithril client wasm in explorer #1426
Conversation
error: `experiments.layers` must be enabled error: webpack import WASM file fail This seems to be a known behaviour.
d31fa69
to
96aad37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I left few comments below
e7a888f
to
0b2d1af
Compare
bee74b8
to
5aaf4f2
Compare
e193566
to
7a2398a
Compare
917e39c
to
8331a8a
Compare
f67a58a
to
a03ddcb
Compare
f135c1a
to
137b1e9
Compare
137b1e9
to
baf3a9c
Compare
baf3a9c
to
7c24c46
Compare
265df91
to
0875c39
Compare
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
19d3ff0
to
7c056eb
Compare
7c056eb
to
c8d2aec
Compare
c8d2aec
to
53e7d53
Compare
…e_chain` feature
- Move function that handles calculation of processing time - Move function that retrieves aggregator network from its url - Rename `init` to `initMithrilClient`
By running 'npm update'
This was done this way to handle the `yarn install` step in the build-test-explorer job. It needs mithril-client-wasm library to be compiled to install the dependency.
… process is in progress.
f9286b2
to
ff3fb20
Compare
- Add build command with make dev - Add 'mithril-client-wasm' compilation in Readme
70d11cf
to
32f6442
Compare
Content
This PR includes the implementation of
mithril-client-wasm
library in the Mithril explorer. It adds a new feature to verify certificates using the WASM library.Pre-submit checklist
Comments
wasm-pack build
command in the Makefile of themithril-client-wasm
lib had to be modified to add the--target web
option. This greatly simplifies the configuration for Next.js projects. Commands executed to build the library in the CI have also been updated.docs.yml
have been moved to the fileci.yml
. This has been done to handle theyarn install
step in the build-test-explorer job.This job needs
mithril-client-wasm
to be built and the artifact published to install the dependency in themithril-explorer
project.Issue(s)
Closes #1409