Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement configurable Chain Observer in aggregator #1423

Merged
merged 6 commits into from
Jan 9, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jan 4, 2024

Content

This PR includes a new Chain Observer builder in the aggregator and the signer that uses a configuration parameter to determine which chain observer to create. This allows to fix the aggregator stress test that imperatively needs to rely on the Cardano Cli chain observer while using the Pallas chain observer by default.

Chain observer types:

Use case Chain Observer Type
Mithril networks infrastructure pallas
End to end tests pallas
Aggregator stress tests cardano-cli

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update documentation website (if relevant)

Issue(s)

Closes #1396

Copy link

github-actions bot commented Jan 4, 2024

Test Results

  3 files  ±0   32 suites  ±0   8m 45s ⏱️ +31s
739 tests ±0  739 ✅ ±0  0 💤 ±0  0 ❌ ±0 
812 runs  ±0  812 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0fb579e. ± Comparison against base commit 673a87d.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/1396-chain-observer-builder-aggregator branch from da6618a to 05dc718 Compare January 4, 2024 12:09
@jpraynaud jpraynaud marked this pull request as ready for review January 4, 2024 13:13
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud jpraynaud self-assigned this Jan 4, 2024
@jpraynaud jpraynaud merged commit d34c487 into main Jan 9, 2024
35 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/1396-chain-observer-builder-aggregator branch January 9, 2024 09:03
@falcucci falcucci mentioned this pull request Jan 9, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ChainObserver adapter configuration in aggregator
3 participants