Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement open_message timeout in aggregator #1401

Merged
merged 9 commits into from
Dec 18, 2023
Merged

Implement open_message timeout in aggregator #1401

merged 9 commits into from
Dec 18, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Dec 15, 2023 •
edited
Loading

Content

This PR includes a mechanism that associates a timeout (or not) to any signed entity type. When an open message is opened for longer than its timeout (if exists), the open message is discarded and thus allows for handling the next open message.

Open message timeouts:

Signed Entity Type Timeout
MithrilStakeDistribution -
CardanoStakeDistribution 600s
CardanoImmutableFilesFull -

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #1387

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 15, 2023 •
edited
Loading

Test Results

    3 files  ±0    32 suites  +2   7m 39s ⏱️ +7s
735 tests +9  735 ✔️ +9  0 💤 ±0  0 ❌ ±0 
804 runs  +9  804 ✔️ +9  0 💤 ±0  0 ❌ ±0 

Results for commit 6bef8fd. ± Comparison against base commit e460fed.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/1387-open-message-timeout branch from 2fbe7c6 to e153132 Compare December 15, 2023 12:09
@jpraynaud jpraynaud force-pushed the jpraynaud/1387-open-message-timeout branch from e153132 to 6290cbd Compare December 15, 2023 12:27
@jpraynaud jpraynaud force-pushed the jpraynaud/1387-open-message-timeout branch from 6290cbd to c62ce3d Compare December 15, 2023 14:12
@jpraynaud jpraynaud self-assigned this Dec 15, 2023
dlachaume
dlachaume approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ghubertpalo
ghubertpalo approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@ghubertpalo ghubertpalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let a simple comment, otherwise GTM.

@jpraynaud jpraynaud force-pushed the jpraynaud/1387-open-message-timeout branch from c62ce3d to 6bef8fd Compare December 18, 2023 10:26
@jpraynaud jpraynaud merged commit b7e4f13 into main Dec 18, 2023
32 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/1387-open-message-timeout branch December 18, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghubertpalo ghubertpalo ghubertpalo approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement open_message timeout in aggregator
3 participants
@jpraynaud @ghubertpalo @dlachaume