-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance machine readable logs in client #1400
Merged
dlachaume
merged 7 commits into
main
from
ensemble/1234/enhance-machine-readable-logs-in-client
Dec 18, 2023
Merged
Enhance machine readable logs in client #1400
dlachaume
merged 7 commits into
main
from
ensemble/1234/enhance-machine-readable-logs-in-client
Dec 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlachaume
temporarily deployed
to
testing-preview
December 15, 2023 12:52
— with
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-preview
December 15, 2023 13:39
— with
GitHub Actions
Inactive
jpraynaud
reviewed
Dec 15, 2023
docs/website/root/manual/developer-docs/nodes/mithril-client.md
Outdated
Show resolved
Hide resolved
ghubertpalo
suggested changes
Dec 15, 2023
docs/website/root/manual/developer-docs/nodes/mithril-client.md
Outdated
Show resolved
Hide resolved
dlachaume
temporarily deployed
to
testing-preview
December 15, 2023 16:35
— with
GitHub Actions
Inactive
dlachaume
force-pushed
the
ensemble/1234/enhance-machine-readable-logs-in-client
branch
from
December 15, 2023 16:42
bc7eb7d
to
fccd874
Compare
dlachaume
temporarily deployed
to
testing-preview
December 15, 2023 16:49
— with
GitHub Actions
Inactive
dlachaume
force-pushed
the
ensemble/1234/enhance-machine-readable-logs-in-client
branch
from
December 18, 2023 11:06
fccd874
to
a3e6629
Compare
dlachaume
temporarily deployed
to
testing-preview
December 18, 2023 11:13
— with
GitHub Actions
Inactive
dlachaume
force-pushed
the
ensemble/1234/enhance-machine-readable-logs-in-client
branch
from
December 18, 2023 11:22
a3e6629
to
8e2400d
Compare
This makes reported JSON logs easier to test
dlachaume
temporarily deployed
to
testing-preview
December 18, 2023 11:29
— with
GitHub Actions
Inactive
dlachaume
force-pushed
the
ensemble/1234/enhance-machine-readable-logs-in-client
branch
from
December 18, 2023 11:31
8e2400d
to
be1a77b
Compare
dlachaume
temporarily deployed
to
testing-preview
December 18, 2023 11:59
— with
GitHub Actions
Inactive
jpraynaud
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
docs/website/root/manual/developer-docs/nodes/mithril-client.md
Outdated
Show resolved
Hide resolved
- Add new parameter `json_output` at a global level - Move `--json` parameter to commands level
dlachaume
force-pushed
the
ensemble/1234/enhance-machine-readable-logs-in-client
branch
from
December 18, 2023 13:27
be1a77b
to
9f17b50
Compare
ghubertpalo
approved these changes
Dec 18, 2023
dlachaume
temporarily deployed
to
testing-preview
December 18, 2023 13:34
— with
GitHub Actions
Inactive
dlachaume
deleted the
ensemble/1234/enhance-machine-readable-logs-in-client
branch
December 18, 2023 13:37
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes an update of
mithril-client-cli
.seconds_left
andseconds_elapsed
("5s" and "001ms" was formatted as "5.1" in logs, instead of "5.001").timestamp
in JSON progress logs.--log-format-json
argument inmithril-client-cli
commands, which displaysslog
logs in json format.--log-output
argument inmithril-client-cli
commands to redirect theslog
logs to a file.Important
This PR includes impacting modifications
mithril-client-cli
. JSON progress logs were modified:bytesDownloaded
is nowbytes_downloaded
bytesTotal
is nowbytes_total
secondsLeft
is nowseconds_left
secondsElapsed
is nowseconds_elapsed
Pre-submit checklist
Issue(s)
Closes #1234