Make mithril-client examples full crates #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlachaume
force-pushed
the
damien/make-mithril-client-examples-full-crates
branch
2 times, most recently
from
808e1b2
to
f3c62ad
Compare
dlachaume
force-pushed
the
damien/make-mithril-client-examples-full-crates
branch
from
f3c62ad
to
901ca66
Compare
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
reviewed
Dec 1, 2023
mithril-client/examples/mithril-client-snapshot-example/Cargo.toml
Outdated
Show resolved
Hide resolved
mithril-client/examples/mithril-client-snapshot-example/Makefile
Outdated
Show resolved
Hide resolved
dlachaume
force-pushed
the
damien/make-mithril-client-examples-full-crates
branch
2 times, most recently
from
34c1cd1
to
74cc66f
Compare
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
reviewed
Dec 1, 2023
dlachaume
force-pushed
the
damien/make-mithril-client-examples-full-crates
branch
from
74cc66f
to
969eff9
Compare
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
dlachaume
force-pushed
the
damien/make-mithril-client-examples-full-crates
branch
3 times, most recently
from
3d4baa8
to
3a0c89b
Compare
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
reviewed
Dec 4, 2023
dlachaume
force-pushed
the
damien/make-mithril-client-examples-full-crates
branch
from
297f4c1
to
ac9b9d5
Compare
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
approved these changes
Dec 4, 2023
dlachaume
force-pushed
the
damien/make-mithril-client-examples-full-crates
branch
from
ac9b9d5
to
8451092
Compare
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
ghubertpalo
approved these changes
Dec 5, 2023
Two seperates crates were created: - `client-snapshot` - `client-mithril-stake-distribution`
+ Fix developer documentation link
dlachaume
force-pushed
the
damien/make-mithril-client-examples-full-crates
branch
from
8451092
to
ea49e91
Compare
This PR updates the `default` feature flag of `mithril-client`
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes the creation of a dedicated crate for each example of the
mithril-clientlibrary.This enhance the DevX for developers that want to implement the library in their own projects. Then now have precisely all the dependencies needed to run the examples.
Pre-submit checklist
Issue(s)
Closes #1385