Fix explorer switch aggregator infinite loop #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This problems occurred when switchin aggregator and was due to infinite loops in useEffect(). The fix is to add 'eslint-disable-line' directive.
dlachaume
approved these changes
Nov 30, 2023
jpraynaud
force-pushed
the
ensemble/fix-explorer-switch-aggregator
branch
from
19104cf
to
8343f6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a fix to the explorer where the switch of the selected aggregator created an infinite loop that flooded the backend. The fix (temporary) is to use the
eslint-disable-linedirective in theuseEffect().Pre-submit checklist