Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout on signer node HTTP requests #1374

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Add timeout on signer node HTTP requests #1374

merged 2 commits into from
Nov 29, 2023

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Nov 28, 2023 •
edited
Loading

Content

This PR includes an update to the AggregatorHTTPClient in the signer node which adds a 15 seconds timeout for HTTP requests.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1312

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2023 •
edited
Loading

Test Results

    3 files  ±0    30 suites  ±0   7m 48s ⏱️ +5s
741 tests +4  741 ✔️ +4  0 💤 ±0  0 ❌ ±0 
849 runs  +4  849 ✔️ +4  0 💤 ±0  0 ❌ ±0 

Results for commit 4e2aadd. ± Comparison against base commit b36415b.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume force-pushed the damien/1312/add-timeout-on-signer-http-clients branch from f4300c0 to 81ada6c Compare November 29, 2023 13:42
jpraynaud
jpraynaud approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume force-pushed the damien/1312/add-timeout-on-signer-http-clients branch from 81ada6c to 4e2aadd Compare November 29, 2023 13:50
@dlachaume dlachaume merged commit 8e9cd93 into main Nov 29, 2023
33 checks passed
@dlachaume dlachaume deleted the damien/1312/add-timeout-on-signer-http-clients branch November 29, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@ghubertpalo ghubertpalo ghubertpalo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signer runtime is stuck for some SPO
3 participants
@dlachaume @jpraynaud @ghubertpalo