Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verbosity log levels #1373

Merged
merged 7 commits into from
Nov 29, 2023
Merged

Fix verbosity log levels #1373

merged 7 commits into from
Nov 29, 2023

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Nov 27, 2023 •
edited
Loading

Content

This PR includes a fix for log levels problems that was raised in the issue #1325.

This consists of:

  • correctly adjust verbosity according to verbosity level (-v, -vv, -vvv)
  • display critical level logs when parameter is absent

Changes have been implemented into:

  • mithril-client-cli
  • mithril-aggregator
  • mithril-signer
  • mithril-relay
  • mithril-test-lab (mithril-end-to-end & stress-test)

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

Log level management has been added to the mithril-end-to-end, as it wasn't already included.

Issue(s)

Closes #1325

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2023 •
edited
Loading

Test Results

    3 files  ±0    30 suites  ±0   7m 27s ⏱️ -32s
737 tests ±0  737 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
845 runs  ±0  845 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit be12adb. ± Comparison against base commit 64140b1.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume force-pushed the damien/1325/fix-verbosity-log-levels branch 2 times, most recently from 4b3c305 to 8fb2d31 Compare November 28, 2023 09:46
@dlachaume dlachaume marked this pull request as ready for review November 28, 2023 10:04
@dlachaume dlachaume force-pushed the damien/1325/fix-verbosity-log-levels branch from 8fb2d31 to d4c66fc Compare November 28, 2023 11:03
@dlachaume dlachaume force-pushed the damien/1325/fix-verbosity-log-levels branch from d4c66fc to 6587303 Compare November 28, 2023 11:22
jpraynaud
jpraynaud approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume force-pushed the damien/1325/fix-verbosity-log-levels branch from 6587303 to be12adb Compare November 29, 2023 09:40
@dlachaume dlachaume merged commit b36415b into main Nov 29, 2023
30 checks passed
@dlachaume dlachaume deleted the damien/1325/fix-verbosity-log-levels branch November 29, 2023 09:50
@dlachaume dlachaume mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@ghubertpalo ghubertpalo ghubertpalo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mithril-client verbosity not following usage menu
3 participants
@dlachaume @jpraynaud @ghubertpalo