Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize default environment file path of Signer node configuration for SPOs #1365

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Nov 22, 2023

Content

This PR includes updates in "Run a Mithril signer as an SPO" guide and in dev blog articles.
The modifications standardize default values for the environment variable DATA_STORES_DIRECTORY and for the environment file path for the signer node.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume changed the title Standardize default values in do Standardize default values in documentation and dev blog articles Nov 22, 2023
@dlachaume dlachaume changed the title Standardize default values in documentation and dev blog articles Standardize default environment file path of Signer node configuration for SPOs Nov 22, 2023
@dlachaume dlachaume force-pushed the damien/fix-default-values-in-doc-and-blog branch from 43d2fd1 to 617e286 Compare November 23, 2023 08:44
@dlachaume dlachaume merged commit 0780dfa into main Nov 23, 2023
7 of 8 checks passed
@dlachaume dlachaume deleted the damien/fix-default-values-in-doc-and-blog branch November 23, 2023 08:58
falcucci pushed a commit to falcucci/mithril that referenced this pull request Nov 28, 2023
…ix-default-values-in-doc-and-blog

Standardize default environment file path of Signer node configuration for SPOs
falcucci pushed a commit to falcucci/mithril that referenced this pull request Nov 28, 2023
…ix-default-values-in-doc-and-blog

Standardize default environment file path of Signer node configuration for SPOs
falcucci pushed a commit to falcucci/mithril that referenced this pull request Nov 28, 2023
…ix-default-values-in-doc-and-blog

Standardize default environment file path of Signer node configuration for SPOs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants