Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP message service #1353

Merged
merged 4 commits into from
Nov 21, 2023
Merged

HTTP message service #1353

merged 4 commits into from
Nov 21, 2023

Conversation

ghubertpalo
Copy link
Collaborator

@ghubertpalo ghubertpalo commented Nov 17, 2023 •
edited
Loading

Content

This PR includes a service that provides entities directly as HTTP messages.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

None

Issue(s)

Relates to #1327

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 17, 2023 •
edited
Loading

Test Results

    3 files  ±0    30 suites  ±0   8m 28s ⏱️ +20s
736 tests +3  736 ✔️ +3  0 💤 ±0  0 ❌ ±0 
844 runs  +3  844 ✔️ +3  0 💤 ±0  0 ❌ ±0 

Results for commit 9a20205. ± Comparison against base commit b17533f.

♻️ This comment has been updated with latest results.

jpraynaud
jpraynaud approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

mithril-aggregator/src/services/http_message.rs Outdated
@@ -0,0 +1,150 @@
//! This service is responsible of provinding HTTP server with messages as fast as possible.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo here:

Suggested change
//! This service is responsible of provinding HTTP server with messages as fast as possible.
//! This service is responsible of providing HTTP server with messages as fast as possible.

@ghubertpalo ghubertpalo merged commit d02447f into main Nov 21, 2023
30 checks passed
@ghubertpalo ghubertpalo deleted the greg/1327/message_service branch November 21, 2023 15:16
falcucci pushed a commit to falcucci/mithril that referenced this pull request Nov 28, 2023
@ghubertpalo
Merge pull request input-output-hk#1353 from input-output-hk/greg/132…
1245bc4 
…7/message_service

HTTP message service
falcucci pushed a commit to falcucci/mithril that referenced this pull request Nov 28, 2023
@ghubertpalo
Merge pull request input-output-hk#1353 from input-output-hk/greg/132…
5e7156c 
…7/message_service

HTTP message service
falcucci pushed a commit to falcucci/mithril that referenced this pull request Nov 28, 2023
@ghubertpalo
Merge pull request input-output-hk#1353 from input-output-hk/greg/132…
da02fdc 
…7/message_service

HTTP message service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghubertpalo @jpraynaud @dlachaume