Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance Aggregator REST API performances #1347

Merged
merged 2 commits into from
Nov 14, 2023
Merged

enhance Aggregator REST API performances #1347

merged 2 commits into from
Nov 14, 2023

Conversation

ghubertpalo
Copy link
Collaborator

@ghubertpalo ghubertpalo commented Nov 14, 2023 •
edited
Loading

Content

This PR includes fixes to enhance Aggregator node REST API performances.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

Regarding SQLite optimization, the following documentations have been found useful:

Issue(s)

Relates to #1327

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited
Loading

Test Results

    3 files  ±0    29 suites  ±0   7m 21s ⏱️ +36s
732 tests ±0  732 ✔️ +14  0 💤 ±0  0 ❌  - 14 
840 runs  ±0  840 ✔️ +14  0 💤 ±0  0 ❌  - 14 

Results for commit c77fa80. ± Comparison against base commit c974b6a.

♻️ This comment has been updated with latest results.

@falcucci falcucci mentioned this pull request Nov 14, 2023
Merged
8 tasks
@jpraynaud
Copy link
Member

Looks good 🙂

Did you run a stress test locally and noticed an improvement of performances?

@ghubertpalo ghubertpalo merged commit 030a315 into main Nov 14, 2023
29 checks passed
@ghubertpalo ghubertpalo deleted the greg/1327/enhance_performances branch November 14, 2023 15:07
falcucci pushed a commit to falcucci/mithril that referenced this pull request Nov 28, 2023
@ghubertpalo
Merge pull request input-output-hk#1347 from input-output-hk/greg/132…
2ca00dd 
…7/enhance_performances

enhance Aggregator SQLite performances
falcucci pushed a commit to falcucci/mithril that referenced this pull request Nov 28, 2023
@ghubertpalo
Merge pull request input-output-hk#1347 from input-output-hk/greg/132…
dd4c113 
…7/enhance_performances

enhance Aggregator SQLite performances
falcucci pushed a commit to falcucci/mithril that referenced this pull request Nov 28, 2023
@ghubertpalo
Merge pull request input-output-hk#1347 from input-output-hk/greg/132…
26d5aad 
…7/enhance_performances

enhance Aggregator SQLite performances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghubertpalo @jpraynaud