Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance end to end readme and fix work_directory default value on MacOS #1338

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Enhance end to end readme and fix work_directory default value on MacOS #1338

merged 2 commits into from
Nov 13, 2023

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Nov 10, 2023 •
edited
Loading

Content

This PR includes updates of mithril-end-to-end related to the the feedback in the PR #1331.

The modifications are linked to issues with the run of the end to end with MacOS:

  • Enhancement of the Readme file to solve the sed issue
  • Replacement of the default value of work_directory as its value was too long

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

@dlachaume
Enhance end-to-end test Readme
8ae81b0 
Add compilation reminder before running end to end tests
Add `gnu-sed` installation instructions
@dlachaume
Change default value for work_directory on MacOS
0311cf0
@github-actions GitHub Actions
Copy link

Test Results

    3 files  ±0    17 suites  ±0   7m 16s ⏱️ + 1m 16s
715 tests ±0  715 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
789 runs  ±0  789 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0311cf0. ± Comparison against base commit 38d4573.

jpraynaud
jpraynaud approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume merged commit 03271e2 into main Nov 13, 2023
26 checks passed
@dlachaume dlachaume deleted the damien/enhance-end-to-end-readme branch November 13, 2023 10:18
falcucci pushed a commit to falcucci/mithril that referenced this pull request Nov 28, 2023
@dlachaume
Merge pull request input-output-hk#1338 from input-output-hk/damien/e…
cd5433a 
…nhance-end-to-end-readme

Enhance end to end readme and fix `work_directory` default value on MacOS
falcucci pushed a commit to falcucci/mithril that referenced this pull request Nov 28, 2023
@dlachaume
Merge pull request input-output-hk#1338 from input-output-hk/damien/e…
7c40950 
…nhance-end-to-end-readme

Enhance end to end readme and fix `work_directory` default value on MacOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@ghubertpalo ghubertpalo Awaiting requested review from ghubertpalo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlachaume @Alenar @jpraynaud