Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client CLI Docker package name in CI/CD #1330

Merged

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Nov 7, 2023

Content

This PR includes a fix for handling a custom Docker package name for the mithril-client-cli in the CI/CD workflows.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #1322

@jpraynaud jpraynaud self-assigned this Nov 7, 2023
Copy link

github-actions bot commented Nov 7, 2023

Test Results

    3 files  ±0    17 suites  ±0   6m 40s ⏱️ -35s
714 tests ±0  714 ✔️ ±0  0 💤 ±0  0 ±0 
788 runs  ±0  788 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 724c39f. ± Comparison against base commit b505c00.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/1322-fix-mithril-client-docker-package-name branch from 9cbdb7b to 724c39f Compare November 7, 2023 09:14
@jpraynaud jpraynaud marked this pull request as ready for review November 7, 2023 09:26
@jpraynaud jpraynaud merged commit ed09c00 into main Nov 7, 2023
26 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/1322-fix-mithril-client-docker-package-name branch November 7, 2023 13:50
falcucci pushed a commit to falcucci/mithril that referenced this pull request Nov 28, 2023
…d/1322-fix-mithril-client-docker-package-name

Fix client CLI Docker package name in CI/CD
falcucci pushed a commit to falcucci/mithril that referenced this pull request Nov 28, 2023
…d/1322-fix-mithril-client-docker-package-name

Fix client CLI Docker package name in CI/CD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants