Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Mithril nodes devnet Docker images #1324

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Enhance Mithril nodes devnet Docker images #1324

merged 4 commits into from
Oct 30, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Oct 30, 2023 •
edited
Loading

Content

This PR includes:

  • Building Docker images by default with the CI images (pre-compiled binaries)
  • Added the possibility to use a different slim image in the CI images
  • Implemented the possibility to use the "legacy" rust builder in the Docker file

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)

Issue(s)

Closes #1272

@jpraynaud jpraynaud self-assigned this Oct 30, 2023
@github-actions
Copy link

Test Results

    3 files  ±0    17 suites  ±0   6m 34s ⏱️ - 1m 47s
714 tests ±0  714 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
788 runs  ±0  788 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b0d78c9. ± Comparison against base commit 01cfd43.

@jpraynaud jpraynaud temporarily deployed to testing-preview October 30, 2023 08:32 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 8b3d245 into main Oct 30, 2023
26 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/1272-fix-docker-images-devnet branch October 30, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix devnet Mithril Docker images
3 participants
@jpraynaud @Alenar @dlachaume