Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing configuration parameters in signer documentation #1317

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Add missing configuration parameters in signer documentation #1317

merged 1 commit into from
Oct 23, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Oct 23, 2023 •
edited
Loading

Content

This PR includes a fix to the Mithril signer documentation for developers that misses 2 important configuration parameters:

  • cardano_cli_path
  • cardano_node_socket_path

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update documentation website (if relevant)

@jpraynaud jpraynaud self-assigned this Oct 23, 2023
@jpraynaud jpraynaud merged commit 8038576 into main Oct 23, 2023
7 of 9 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/fix-doc-signer-developer branch October 23, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlachaume dlachaume dlachaume approved these changes

@Alenar Alenar Awaiting requested review from Alenar

@ghubertpalo ghubertpalo Awaiting requested review from ghubertpalo

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpraynaud @dlachaume