Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add soft limit in certificate query #1314

Merged
merged 2 commits into from
Oct 25, 2023
Merged

add soft limit in certificate query #1314

merged 2 commits into from
Oct 25, 2023

Conversation

ghubertpalo
Copy link
Collaborator

@ghubertpalo ghubertpalo commented Oct 20, 2023 •
edited by Alenar
Loading

Content

This PR includes a limit in Certificate SQL queries in order to speed up runtime.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

The implementation follows some guidelines of SQL good practices.

Issue(s)

Relates to #1310

@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

Test Results

    3 files  ±0    17 suites  ±0   8m 19s ⏱️ + 1m 40s
713 tests ±0  713 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
787 runs  ±0  787 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4ed563e. ± Comparison against base commit 1769cbd.

♻️ This comment has been updated with latest results.

@ghubertpalo ghubertpalo temporarily deployed to testing-preview October 20, 2023 15:42 — with GitHub Actions Inactive
@jpraynaud jpraynaud marked this pull request as ready for review October 25, 2023 16:25
jpraynaud
jpraynaud approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this 👍

@ghubertpalo ghubertpalo temporarily deployed to testing-preview October 25, 2023 16:46 — with GitHub Actions Inactive
@Alenar Alenar merged commit 8df0952 into main Oct 25, 2023
26 checks passed
@Alenar Alenar deleted the greg/1310/sql_limit branch October 25, 2023 16:53
@jpraynaud jpraynaud mentioned this pull request Oct 26, 2023
Closed
6 tasks
@ghubertpalo ghubertpalo mentioned this pull request Nov 6, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghubertpalo @jpraynaud @Alenar