Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signers registered route to aggregator #1129

Merged
merged 5 commits into from
Aug 3, 2023
Merged

Add signers registered route to aggregator #1129

merged 5 commits into from
Aug 3, 2023

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Aug 3, 2023 •
edited
Loading

Content

This PR add a new route to the aggregator, /signers/registered/{epoch}, that allow to retrieve the signer registration for a given epoch.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Relates to #1097

@Alenar Alenar requested a review from jpraynaud August 3, 2023 08:10
@github-actions
Copy link

github-actions bot commented Aug 3, 2023 •
edited
Loading

Test Results

    3 files  ±0    16 suites  ±0   6m 34s ⏱️ +15s
654 tests +8  654 ✔️ +8  0 💤 ±0  0 ❌ ±0 
692 runs  +8  692 ✔️ +8  0 💤 ±0  0 ❌ ±0 

Results for commit b282f94. ± Comparison against base commit d4ac66d.

♻️ This comment has been updated with latest results.

@Alenar Alenar temporarily deployed to testing-preview August 3, 2023 08:19 — with GitHub Actions Inactive
jpraynaud
jpraynaud reviewed Aug 3, 2023
View reviewed changes
mithril-aggregator/src/entities/signer_registration_message.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/entities/signer_registration_message.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/database/provider/signer_registration.rs Outdated Show resolved Hide resolved
openapi.yaml Outdated Show resolved Hide resolved
openapi.yaml Outdated Show resolved Hide resolved
mithril-aggregator/src/http_server/routes/signer_routes.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/http_server/routes/signer_routes.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/entities/signer_registration_message.rs Outdated Show resolved Hide resolved
@Alenar Alenar force-pushed the djo/1097/add-signers-registered-route-to-aggregator branch from a4050c7 to 513d303 Compare August 3, 2023 09:16
@Alenar Alenar temporarily deployed to testing-preview August 3, 2023 09:25 — with GitHub Actions Inactive
@Alenar Alenar force-pushed the djo/1097/add-signers-registered-route-to-aggregator branch from 513d303 to b22b80a Compare August 3, 2023 10:11
jpraynaud
jpraynaud approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Alenar Alenar temporarily deployed to testing-preview August 3, 2023 10:25 — with GitHub Actions Inactive
@Alenar Alenar merged commit cd56f53 into main Aug 3, 2023
24 checks passed
@Alenar Alenar deleted the djo/1097/add-signers-registered-route-to-aggregator branch August 3, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alenar @jpraynaud