Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregator refactoring: services and dependencies container #1057

Merged
merged 7 commits into from
Jul 13, 2023

Conversation

ghubertpalo
Copy link
Collaborator

@ghubertpalo ghubertpalo commented Jul 13, 2023

Content

This PR includes a rework of the Aggregator's code in order to tidy up its code:

  • It gather all code related to dependency management into the dependency_injection module and rename the builded containers to DependencyContainer (from DependencyManager).
  • It move all services that were at the source top level into a new services module.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

None

Issue(s)

Closes #1058

@github-actions
Copy link

github-actions bot commented Jul 13, 2023

Test Results

    3 files  ±0    16 suites  ±0   4m 56s ⏱️ -47s
635 tests ±0  635 ✔️ ±0  0 💤 ±0  0 ±0 
673 runs  ±0  673 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 1ffaf6a. ± Comparison against base commit 12e3af1.

This pull request removes 22 and adds 22 tests. Note that renamed tests count towards both.
mithril-aggregator ‑ certifier_service::tests::should_clean_epoch_when_inform_epoch
mithril-aggregator ‑ certifier_service::tests::should_create_certificate_when_multi_signature_produced
mithril-aggregator ‑ certifier_service::tests::should_not_create_certificate_for_open_message_already_certified
mithril-aggregator ‑ certifier_service::tests::should_not_create_certificate_for_open_message_not_created
mithril-aggregator ‑ certifier_service::tests::should_not_create_certificate_when_no_multi_signature_produced
mithril-aggregator ‑ certifier_service::tests::should_not_register_invalid_single_signature
mithril-aggregator ‑ certifier_service::tests::should_not_register_single_signature_for_certified_open_message
mithril-aggregator ‑ certifier_service::tests::should_register_valid_single_signature
mithril-aggregator ‑ certifier_service::tests::test_epoch_gap_certificate_chain
mithril-aggregator ‑ certifier_service::tests::test_epoch_gap_certificate_chain_ok
…
mithril-aggregator ‑ services::certifier::tests::should_clean_epoch_when_inform_epoch
mithril-aggregator ‑ services::certifier::tests::should_create_certificate_when_multi_signature_produced
mithril-aggregator ‑ services::certifier::tests::should_not_create_certificate_for_open_message_already_certified
mithril-aggregator ‑ services::certifier::tests::should_not_create_certificate_for_open_message_not_created
mithril-aggregator ‑ services::certifier::tests::should_not_create_certificate_when_no_multi_signature_produced
mithril-aggregator ‑ services::certifier::tests::should_not_register_invalid_single_signature
mithril-aggregator ‑ services::certifier::tests::should_not_register_single_signature_for_certified_open_message
mithril-aggregator ‑ services::certifier::tests::should_register_valid_single_signature
mithril-aggregator ‑ services::certifier::tests::test_epoch_gap_certificate_chain
mithril-aggregator ‑ services::certifier::tests::test_epoch_gap_certificate_chain_ok
…

♻️ This comment has been updated with latest results.

@ghubertpalo ghubertpalo temporarily deployed to testing-preview July 13, 2023 07:43 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo temporarily deployed to testing-preview July 13, 2023 07:59 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo requested review from Alenar and jpraynaud and removed request for Alenar July 13, 2023 08:14
@ghubertpalo ghubertpalo marked this pull request as ready for review July 13, 2023 08:14
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

A more specific/detailed name for the PR is welcome!

@jpraynaud jpraynaud linked an issue Jul 13, 2023 that may be closed by this pull request
@ghubertpalo ghubertpalo changed the title Greg/refacto Aggregator refactoring: services and dependencies container Jul 13, 2023
@ghubertpalo ghubertpalo merged commit 3aa3c21 into main Jul 13, 2023
13 checks passed
@ghubertpalo ghubertpalo deleted the greg/refacto branch July 13, 2023 10:18
@ghubertpalo ghubertpalo temporarily deployed to testing-preview July 13, 2023 10:29 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor aggregator dependency injection and services
3 participants