-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggregator refactoring: services and dependencies container #1057
Conversation
Test Results 3 files ±0 16 suites ±0 4m 56s ⏱️ -47s Results for commit 1ffaf6a. ± Comparison against base commit 12e3af1. This pull request removes 22 and adds 22 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
1fb24ae
to
1ffaf6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
A more specific/detailed name for the PR is welcome!
Content
This PR includes a rework of the Aggregator's code in order to tidy up its code:
dependency_injection
module and rename the builded containers toDependencyContainer
(fromDependencyManager
).services
module.Pre-submit checklist
Comments
None
Issue(s)
Closes #1058