Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix QA issues #1034

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Fix QA issues #1034

merged 5 commits into from
Jul 6, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jul 5, 2023 •
edited
Loading

Content

This PR includes some fixes following QA team review:

  • Fix failing curl commands in devnet
  • Fix mithril nodes logs not displaying properly in devnet
  • Replace usage of docker-compose with docker compose:
    • in devnet
    • in infra
  • Fix typo in explorer

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@jpraynaud jpraynaud self-assigned this Jul 5, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023 •
edited
Loading

Test Results

    3 files  ±0    16 suites  ±0   5m 30s ⏱️ -3s
613 tests ±0  613 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
651 runs  ±0  651 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 12f7461. ± Comparison against base commit d357e91.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview July 5, 2023 17:08 — with GitHub Actions Inactive
@jpraynaud jpraynaud linked an issue Jul 6, 2023 that may be closed by this pull request
Q&A followup fixes #1035
Closed
6 tasks
@jpraynaud jpraynaud temporarily deployed to testing-preview July 6, 2023 07:57 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 6b37c1e into main Jul 6, 2023
@jpraynaud jpraynaud deleted the jpraynaud/fix-qa-issues branch July 6, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@ghubertpalo ghubertpalo Awaiting requested review from ghubertpalo

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Q&A followup fixes
2 participants
@jpraynaud @Alenar