refactor: rename function and clarify some comments after review

- Rename function 'allow_unparsable_block' to 'compute_allow_unparsable_block' and clarify its comment
- Add reference to pre-production network in 'allow_unparsable_block' comments

.github/workflows/actions/deploy-terraform-infrastructure/action.yml

@@ -101,7 +101,7 @@ inputs:
     description: CExplorer url of the list of pools that is used by the mithril aggregator.
     required: false
   mithril_aggregator_allow_unparsable_block:
-    description: If set no error is returned in case of unparsable block and an error log is written instead. Will be ignored on production networks.
+    description: If set no error is returned in case of unparsable block and an error log is written instead. Will be ignored on (pre)production networks.
     required: false
     default: "false"
   prometheus_auth_username:

docs/website/root/manual/developer-docs/nodes/mithril-aggregator.md

@@ -445,7 +445,7 @@ Here is a list of the available parameters:
 | `signed_entity_types` | `--signed-entity-types` | - | `SIGNED_ENTITY_TYPES` | Signed entity types parameters (discriminants names in an ordered comma separated list) | - | `MithrilStakeDistribution,CardanoImmutableFilesFull,CardanoStakeDistribution` | - |
 | `snapshot_compression_algorithm` | `--snapshot-compression-algorithm` | - | `SNAPSHOT_COMPRESSION_ALGORITHM` | Compression algorithm of the snapshot archive | `zstandard` | `gzip` or `zstandard` | - |
 | `zstandard_parameters` | - | - | `ZSTANDARD_PARAMETERS__LEVEL` and `ZSTANDARD_PARAMETERS__NUMBER_OF_WORKERS` | Zstandard specific parameters | - | `{ level: 9, number_of_workers: 4 }` | - |
-| `allow_unparsable_block` | `--allow-unparsable-block` | - | `ALLOW_UNPARSABLE_BLOCK` | If set no error is returned in case of unparsable block and an error log is written instead. Will be ignored on production networks. | `false` | - | - |
+| `allow_unparsable_block` | `--allow-unparsable-block` | - | `ALLOW_UNPARSABLE_BLOCK` | If set no error is returned in case of unparsable block and an error log is written instead. Will be ignored on (pre)production networks. | `false` | - | - |
 
 `genesis bootstrap` command:
 

docs/website/root/manual/developer-docs/nodes/mithril-signer.md

@@ -165,7 +165,7 @@ Options:
       --allow-unparsable-block
           If set no error is returned in case of unparsable block and an error log is written instead.
 
-          Will be ignored on production networks.
+          Will be ignored on (pre)production networks.
 
   -h, --help
           Print help (see a summary with '-h')
@@ -251,4 +251,4 @@ Here is a list of the available parameters:
 | `enable_metrics_server` | `--enable-metrics-server` | - | `ENABLE_METRICS_SERVER` | Enable metrics HTTP server (Prometheus endpoint on /metrics) | `false` | - | - |
 | `metrics_server_ip` | `--metrics-server-ip` | - | `METRICS_SERVER_IP` | Metrics HTTP server IP | `0.0.0.0` | - | - |
 | `metrics_server_port` | `--metrics-server-port` | - | `METRICS_SERVER_PORT` | Metrics HTTP server listening port | `9090` | - | - |
-| `allow_unparsable_block` | `--allow-unparsable-block` | - | `ALLOW_UNPARSABLE_BLOCK` | If set no error is returned in case of unparsable block and an error log is written instead. Will be ignored on production networks. | `false` | - | - |
+| `allow_unparsable_block` | `--allow-unparsable-block` | - | `ALLOW_UNPARSABLE_BLOCK` | If set no error is returned in case of unparsable block and an error log is written instead. Will be ignored on (pre)production networks. | `false` | - | - |

mithril-aggregator/src/commands/serve_command.rs

@@ -39,7 +39,7 @@ pub struct ServeCommand {
 
     /// If set no error is returned in case of unparsable block and an error log is written instead.
     ///
-    /// Will be ignored on production networks.
+    /// Will be ignored on (pre)production networks.
     #[clap(long)]
     allow_unparsable_block: bool,
 }

mithril-aggregator/src/configuration.rs

@@ -150,7 +150,7 @@ pub struct Configuration {
 
     /// If set no error is returned in case of unparsable block and an error log is written instead.
     ///
-    /// Will be ignored on production networks.
+    /// Will be ignored on (pre)production networks.
     pub allow_unparsable_block: bool,
 }
 
@@ -357,7 +357,7 @@ pub struct DefaultConfiguration {
 
     /// If set no error is returned in case of unparsable block and an error log is written instead.
     ///
-    /// Will be ignored on production networks.
+    /// Will be ignored on (pre)production networks.
     pub allow_unparsable_block: String,
 }
 

mithril-aggregator/src/dependency_injection/builder.rs

@@ -718,7 +718,7 @@ impl DependenciesBuilder {
             self.get_logger().await?,
             self.configuration
                 .get_network()?
-                .allow_unparsable_block(self.configuration.allow_unparsable_block)?,
+                .compute_allow_unparsable_block(self.configuration.allow_unparsable_block)?,
         );
 
         Ok(Arc::new(transaction_parser))

mithril-common/src/entities/cardano_network.rs

@@ -75,9 +75,8 @@ impl CardanoNetwork {
         }
     }
 
-    /// Evaluate the possibility of validating the request to allow unparsable block or not,
-    /// depending on the target Cardano network
-    pub fn allow_unparsable_block(&self, allow_unparsable_block: bool) -> StdResult<bool> {
+    /// Determines whether unparsable blocks should be allowed based on the specific Cardano network.
+    pub fn compute_allow_unparsable_block(&self, allow_unparsable_block: bool) -> StdResult<bool> {
         let allow_unparsable_block = match self {
             CardanoNetwork::MainNet => false,
             CardanoNetwork::TestNet(id) if *id == PREPROD_MAGIC_ID => false,
@@ -160,22 +159,22 @@ mod tests {
     #[test]
     fn allow_unparsable_block_should_always_return_false_on_mainnet_and_preprod() {
         let allow_unparsable_block = CardanoNetwork::MainNet
-            .allow_unparsable_block(false)
+            .compute_allow_unparsable_block(false)
             .unwrap();
         assert!(!allow_unparsable_block);
 
         let allow_unparsable_block = CardanoNetwork::MainNet
-            .allow_unparsable_block(true)
+            .compute_allow_unparsable_block(true)
             .unwrap();
         assert!(!allow_unparsable_block);
 
         let allow_unparsable_block = CardanoNetwork::TestNet(PREPROD_MAGIC_ID)
-            .allow_unparsable_block(false)
+            .compute_allow_unparsable_block(false)
             .unwrap();
         assert!(!allow_unparsable_block);
 
         let allow_unparsable_block = CardanoNetwork::TestNet(PREPROD_MAGIC_ID)
-            .allow_unparsable_block(true)
+            .compute_allow_unparsable_block(true)
             .unwrap();
         assert!(!allow_unparsable_block);
     }
@@ -184,42 +183,42 @@ mod tests {
     fn allow_unparsable_block_should_return_value_passed_in_parameter_on_all_networks_other_than_mainnet_and_preprod(
     ) {
         let allow_unparsable_block = CardanoNetwork::TestNet(PREVIEW_MAGIC_ID)
-            .allow_unparsable_block(false)
+            .compute_allow_unparsable_block(false)
             .unwrap();
         assert!(!allow_unparsable_block);
 
         let allow_unparsable_block = CardanoNetwork::TestNet(PREVIEW_MAGIC_ID)
-            .allow_unparsable_block(true)
+            .compute_allow_unparsable_block(true)
             .unwrap();
         assert!(allow_unparsable_block);
 
         let allow_unparsable_block = CardanoNetwork::TestNet(SANCHONET_MAGIC_ID)
-            .allow_unparsable_block(false)
+            .compute_allow_unparsable_block(false)
             .unwrap();
         assert!(!allow_unparsable_block);
 
         let allow_unparsable_block = CardanoNetwork::TestNet(SANCHONET_MAGIC_ID)
-            .allow_unparsable_block(true)
+            .compute_allow_unparsable_block(true)
             .unwrap();
         assert!(allow_unparsable_block);
 
         let allow_unparsable_block = CardanoNetwork::TestNet(TESTNET_MAGIC_ID)
-            .allow_unparsable_block(false)
+            .compute_allow_unparsable_block(false)
             .unwrap();
         assert!(!allow_unparsable_block);
 
         let allow_unparsable_block = CardanoNetwork::TestNet(TESTNET_MAGIC_ID)
-            .allow_unparsable_block(true)
+            .compute_allow_unparsable_block(true)
             .unwrap();
         assert!(allow_unparsable_block);
 
         let allow_unparsable_block = CardanoNetwork::DevNet(123)
-            .allow_unparsable_block(false)
+            .compute_allow_unparsable_block(false)
             .unwrap();
         assert!(!allow_unparsable_block);
 
         let allow_unparsable_block = CardanoNetwork::DevNet(123)
-            .allow_unparsable_block(true)
+            .compute_allow_unparsable_block(true)
             .unwrap();
         assert!(allow_unparsable_block);
     }

mithril-infra/variables.tf

@@ -251,7 +251,7 @@ variable "mithril_aggregator_cexplorer_pools_url" {
 
 variable "mithril_aggregator_allow_unparsable_block" {
   type        = bool
-  description = "If set no error is returned in case of unparsable block and an error log is written instead. Will be ignored on production networks."
+  description = "If set no error is returned in case of unparsable block and an error log is written instead. Will be ignored on (pre)production networks."
   default     = false
 }
 

mithril-signer/src/configuration.rs

@@ -93,7 +93,7 @@ pub struct Configuration {
 
     /// If set no error is returned in case of unparsable block and an error log is written instead.
     ///
-    /// Will be ignored on production networks.
+    /// Will be ignored on (pre)production networks.
     pub allow_unparsable_block: bool,
 }
 

mithril-signer/src/main.rs

@@ -78,7 +78,7 @@ pub struct Args {
 
     /// If set no error is returned in case of unparsable block and an error log is written instead.
     ///
-    /// Will be ignored on production networks.
+    /// Will be ignored on (pre)production networks.
     #[clap(long)]
     allow_unparsable_block: bool,
 }

mithril-signer/src/runtime/signer_services.rs

@@ -261,7 +261,7 @@ impl<'a> ServiceBuilder for ProductionServiceBuilder<'a> {
             slog_scope::logger(),
             self.config
                 .get_network()?
-                .allow_unparsable_block(self.config.allow_unparsable_block)?,
+                .compute_allow_unparsable_block(self.config.allow_unparsable_block)?,
         ));
         let transaction_store = Arc::new(CardanoTransactionRepository::new(
             transaction_sqlite_connection,