Correct binary size of praos/genesis proof in format.md #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to be out of date.
3 tasks
iohk-bors bot
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Sep 12, 2019
701: Correct proof-length of praos/genesis blocks r=Anviking a=Anviking # Issue Number #698 # Overview - [x] I adjusted the expected proof-length - [x] I added a test case for the previously failing block (it fails without the fix, succeeds with the fix) - [x] Extra: I renamed the arbitrary `block-n.bin` to `arbitrary-block-n.bin` # Comments Seems like a small arithmetic mistake in the docs: <img width="439" alt="Skärmavbild 2019-09-12 kl 09 44 27" src="https://user-images.githubusercontent.com/304423/64764231-ed292d00-d541-11e9-977b-51ecbbb7066b.png"> individual components add up to 612 and not 616. I proposed a fix: input-output-hk/chain-libs#93 <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
Anviking
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
cardano-walletwe don't do anything with the block proofs, but we do verify that they have one of the possible correct sizes:0,96,616according to theformat.mddocument.When decoding the following block, it seems like it should be 612.
The sum of the components in the document is also in fact 612:
484+96+32= 612.