Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add initial DevX #63

Merged
merged 19 commits into from
Oct 9, 2024
Merged

feat: add initial DevX #63

merged 19 commits into from
Oct 9, 2024

Conversation

apskhem
Copy link
Contributor

@apskhem apskhem commented Oct 4, 2024 •
edited
Loading

Closes #65

Demo Command

go run cmd/main.go devx cmd/testdata/devx/Developer.md extra-cool-command

@apskhem apskhem added the enhancement New feature or request label Oct 4, 2024
@apskhem apskhem self-assigned this Oct 4, 2024
@apskhem apskhem linked an issue Oct 4, 2024 that may be closed by this pull request
Integrate Developer Experience Documentation/Scripting into Catalyst Forge #55
Open
2 tasks
@apskhem apskhem changed the title feat: Add initial DevX feat: add initial DevX Oct 4, 2024
@apskhem apskhem marked this pull request as draft October 4, 2024 14:25
@apskhem apskhem force-pushed the feat/initial-devx branch 2 times, most recently from 41ebf06 to add3272 Compare October 7, 2024 11:58
@apskhem apskhem marked this pull request as ready for review October 7, 2024 12:06
jmgilman
jmgilman requested changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@jmgilman jmgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start with the changes noted here and then I'll review again after you're finished. Thanks for helping out! :)

cli/cmd/cmds/devx.go Outdated Show resolved Hide resolved
cli/cmd/cmds/devx.go Outdated Show resolved Hide resolved
cli/cmd/testdata/devx/Developer.md Outdated Show resolved Hide resolved
cli/cmd/cmds/devx.go Outdated Show resolved Hide resolved
@apskhem apskhem requested a review from jmgilman October 8, 2024 11:43
@apskhem apskhem changed the base branch from master to feat/devx October 8, 2024 11:53
@apskhem apskhem merged commit e88faa3 into feat/devx Oct 9, 2024
20 checks passed
@apskhem apskhem deleted the feat/initial-devx branch October 9, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenj stevenj Awaiting requested review from stevenj

@jmgilman jmgilman Awaiting requested review from jmgilman

Assignees

@apskhem apskhem

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@apskhem @stevenj @jmgilman