Update ADR-4: Replace CurrentEra & UpcomingEra with concrete era names #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbolymer
force-pushed
the
mgalazyn/adr-4-use-specific-eras-instead-of-current-upcoming
branch
from
7019aa0
to
d26356e
Compare
carbolymer
changed the title
carbolymer
force-pushed
the
mgalazyn/adr-4-use-specific-eras-instead-of-current-upcoming
branch
from
d26356e
to
9f6be99
Compare
carbolymer
commented
Jul 29, 2024
|
|
||
| This deprecation will happen only after the hardfork has been successful. There should be no need for consumers of the api to need the prior era's specific functionality. If users for some reason want this, we can direct them to use the ledger's api directly. | ||
|
|
||
| ## Downsides |
There was a problem hiding this comment.
I don't think this description of downsides is relevant anymore, so I've removed it: the dead code won't be an issue anymore.
Jimbo4350
approved these changes
Aug 28, 2024
| The new api should be created adjacant to the existing one. | ||
| We then slowly replace the use of the existing api in cardano-api, eventually deprecating the "old" api. | ||
|
|
||
| With respect to cardano-cli, we should introduce top level `current-era` and `upcoming-era` commands. |
There was a problem hiding this comment.
Thinking about this again we should just use the era. Why? These names would have the same problem we just ran into with cardano-cli latest.
There was a problem hiding this comment.
I think I agree with you. On the era boundary this will break most of the scripts relying on the latest being a particular era.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
CurrentEraandUpcomingErawith the concrete eras names.Rendered