Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: upgrade Kotlin, tools & CI #11

Merged
merged 1 commit into from
Jan 11, 2024
Merged

build: upgrade Kotlin, tools & CI #11

merged 1 commit into from
Jan 11, 2024

Conversation

hamada147
Copy link
Contributor

Overview

Fixes #

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@hamada147 hamada147 added the enhancement New feature or request label Jan 10, 2024
@hamada147 hamada147 self-assigned this Jan 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2024 •
edited
Loading

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit d533091.

♻️ This comment has been updated with latest results.

@hamada147 hamada147 force-pushed the update branch 5 times, most recently from ec883c3 to 5393a21 Compare January 10, 2024 14:12
@input-output-hk input-output-hk deleted a comment from atala-dev Jan 10, 2024
@hamada147 hamada147 force-pushed the update branch 3 times, most recently from 41db3c8 to 0eab01a Compare January 11, 2024 10:53
cristianIOHK
cristianIOHK reviewed Jan 11, 2024
View reviewed changes
gradle.properties Outdated Show resolved Hide resolved
cristianIOHK
cristianIOHK approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@cristianIOHK cristianIOHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments to take care off before merging.

@hamada147
build: upgrade Kotlin, tools & CI
d533091 
Signed-off-by: Ahmed Moussa <ahmed.moussa@iohk.io>
@hamada147 hamada147 merged commit 1c28c9c into main Jan 11, 2024
3 checks passed
@hamada147 hamada147 deleted the update branch January 11, 2024 13:49
github-actions bot pushed a commit that referenced this pull request Jan 11, 2024
@hamada147
feat(docs): (1c28c9c) build: upgrade Kotlin, tools & CI (#11)
7cf004a 
Signed-off-by: Ahmed Moussa <ahmed.moussa@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianIOHK cristianIOHK cristianIOHK approved these changes

@elribonazo elribonazo Awaiting requested review from elribonazo

@FabioPinheiro FabioPinheiro Awaiting requested review from FabioPinheiro

@mineme0110 mineme0110 Awaiting requested review from mineme0110

@goncalo-frade-iohk goncalo-frade-iohk Awaiting requested review from goncalo-frade-iohk

Assignees

@hamada147 hamada147

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamada147 @cristianIOHK