Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: using ESM #228

Merged
merged 3 commits into from
Aug 26, 2023
Merged

refactor!: using ESM #228

merged 3 commits into from
Aug 26, 2023

Conversation

dragon-fish
Copy link
Member

  • build!: replace webpack with vite
  • refactor!: replace cjs with esm

Dragon-Fish added 3 commits August 24, 2023 17:35
build!: replace webpack with vite
refactor!: replace cjs with esm
@dragon-fish dragon-fish requested a review from AlPha5130 August 24, 2023 11:29
Comment on lines +1 to +13
import {
h,
createApp,
defineComponent,
ref,
computed,
onMounted,
onBeforeUnmount,
//@ts-ignore
} from 'https://unpkg.com/vue@3/dist/vue.runtime.esm-browser.prod.js?module'

// main
;(async () => {

Check notice

Code scanning / CodeQL

Unused variable, import, function or class

Unused import onMounted.
Copy link
Contributor

@AlPha5130 AlPha5130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dragon-fish dragon-fish merged commit e3d9318 into master Aug 26, 2023
@dragon-fish dragon-fish deleted the dragon-fish/refactor-esm branch August 26, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants