feat: add flag to not open the browser automatically #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelEischer
requested changes
Jul 5, 2024
alxndr13
force-pushed
the
open-browser-flag
branch
from
b75744a to
0944848
Compare
|
@MichaelEischer thanks for the heads up. I had some changes that I hadn't committed yet. They are committed now, please take a look. :) I was surprised when you mentioned that this variable wasn't used. I've been using my custom build for four weeks without issues, but I guess I need to commit my changes. 😄 |
MichaelEischer
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes i want to authenticate using an incognito window, but calendarsync opens the auth dialog in the last recent window i used. To make sure i can select which browser, window or profile i want to use for the authentication, i can now add the flag
--open-browser falseto get a link which can be copied to the browser or window the user selects.